Feature/DO-1834 Header Change Detection add HTTP status flags for custom behaviour for BigCommerce#1464
Merged
aaronmedina-dev merged 3 commits intomainfrom Mar 24, 2025
Conversation
added 2 commits
March 21, 2025 15:45
…us, ie 406 for BigCommerce
… SerializationException Added parameter to accept custom http status
aaronmedina-dev
requested review from
AdamJHall,
TheOrangePuff,
crispy101,
finnholland,
hubertott and
porhkz
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
TheOrangePuff
requested changes
Mar 23, 2025
Member
TheOrangePuff
left a comment
TheOrangePuff
left a comment
There was a problem hiding this comment.
Looks good! Just a question and the Aikido recommendation needs review :)
Contributor
Author
I think for our use case, this is not applicable? Our URLs are passed as props to the construct at deploy time and not at runtime, so there's no user input that would allow SSRF exploitation (?). |
TheOrangePuff
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Screenshots (if applicable)
Before the change
After the Change
Test with added 406 status
Test without the 406
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback